Supports strict JSON formats, fix basic authentication issues, general error message improvements #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed
Strict JSON formats
Some third party services are very strict about their JSON definitions, not allowing fields to be enclosed by
'
and require"
instead. Some also don't like JSON arrays with a trailing,
at the last element.We fixed this by making sure we use quotation marks
"
for fields and values, as well as removing trailing commas on the last element of a JSON array.Readability for basic authentication
Improved readability for how the basic authentication is calculated. Future implementations can implemented different authz options here.
General exception improvements
Instead of having "uh oh something went wrong", improved error messaging.